I’ve done a fair chunk of research in drinking bottles. There are four main types, glass, stainless steel, aluminium and plastic. All have their pros and cons. Glass is probably the nicest to drink from, easy to clean, but does break pretty easy. Plastic is probably the most practical, it’s cheap, hard to break and easy to clean (shaker have a wide neck so you can actually get your hard inside and get to the hard to reach places), but they can smell a bit.
Stainless steel seems to offer a compromise between plastic and glass. It’s unbreakable, doesn’t smell, but is a bit more expensive. So for me it seems to be horses for courses.
My plan is to use a shaker for the gym like this:
A glass one for around house, like this:
And a stainless steel one at all other times: